Update: C-rate clipping not accounted for in annual_excess_gen?

[StuartJames]

Thanks a lot for doublechecking Nicky! I am genuinely glad that these issues seem legit.

As for the non-applied self-discharge:

@nicky_middleton22

Also worth noting: there seem’s to be an unrelated no-op at line 140 (self-discharge isn’t actually applied to soc, since the result of soc - 0.0002 * soc is never assigned). Small thing, but maybe worth its own quick PR.

This one I have already flagged in May ( Clarification on battery self-discharge implementation in hour_simulation (SOC not updated?) ) and got a response and confirmation from @AndreasSahlberg. I have recently submitted the according Pull Request: “Fix battery self-discharge implementation - #165” after my first Pull Request had failed in May (must have been a mistake on my side - was still pretty new with GitHub at that stage).

So, yes. I am very happy to make a clean suggestion on this:

@nicky_middleton22

One thing worth adding before this is ready to merge: could you post how soc itself gets updated under the rewrite?

and will be looking forward to your feedback.

All the best,

Stuart